grpc / grpc/grpc-node

`createFromGoogleCredential` is not compatible with `google-auth-library` 10.x.x

Open
#2,993 3 comments 4 reactions 0 assignees View on GitHub
package: @grpc/grpc-js
Dominant language
TypeScript
Stars
4.8k
Forks
716
Avg merge
2d 3h
Merged PRs (30d)
10

Description

### Problem description
`google-auth-library` 10.x adopted and moved forward to node native fetch. Thus they switched from
```ts
export interface Headers {
[index: string]: string;
}
```
to Headers defined in Node.

`createFromGoogleCredential` uses the following interface

```ts
export interface CurrentOAuth2Client {
getRequestHeaders: (url?: string) => Promise<{
[index: string]: string;
}>;
}
```
which is incompatible.

### Reproduction steps
Try `createFromGoogleCredential` with a client created with google-auth-library 10.x

### Environment
- OS name, version and architecture: aarch64, MacOS
- Node version: 21
- Node installation method: volta
- If applicable, compiler version [e.g. clang 3.8.0-2ubuntu4]
- Package name and version "@grpc/grpc-js": "^1.13.0",

### Additional context

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.