grpc / grpc/grpc-node

Remove @grpc/proto-loader from @grpc/grpc-js

Open
#2,943 2 comments 0 reactions 0 assignees View on GitHub
package: @grpc/grpc-js
Dominant language
TypeScript
Stars
4.8k
Forks
716
Avg merge
2d 3h
Merged PRs (30d)
10

Description

### Is your feature request related to a problem?

Right now, the grpc-js package is install the proto-loader package (which I'm 100% sure it doesn't need). I suggest removing the proto-loader package from the grpc-js dependencies.

### Describe the solution you'd like
To import channelZ (if someone needs it), grpc-js can use code generation of any of dozens of other packages that create physical files and can work in environments where there is no node_modules folder. In this way, we will fix two problems - unnecessary dependency and work in production environments (where the use of node_modules is prohibited and there are requirements for bundling the application into a single js file)

### Describe alternatives you've considered
protobufjs-cli, protobuf-ts, @bufbuild/protobuf and many others.

### Additional context
See how many unnecessary dependencies I need to install: https://npmgraph.js.org/?q=%40grpc%2Fgrpc-js. And every such unnecessary dependency is a potential place to attack.

### Notes
For me, i can "omit" via overrides:
```
"@grpc/proto-loader": "npm:dry-uninstall"
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.