grpc / grpc/grpc-node

Servers base64-encode “grpc-status-details-bin” header with padding, but should be unpadded

Open
#2,765 1 comment 0 reactions 0 assignees View on GitHub
package: @grpc/grpc-js
Dominant language
TypeScript
Stars
4.8k
Forks
716
Avg merge
2d 3h
Merged PRs (30d)
10

Description

The spec for gRPC states that implementations should emit binary headers using *unpadded* base64-encoding (emphasis mine):

> Note that HTTP2 does not allow arbitrary octet sequences for header values so binary header values must be encoded using Base64 as per https://tools.ietf.org/html/rfc4648#section-4. Implementations MUST accept padded and un-padded values ***and should emit un-padded values***.
>

However, the server in this repo emits a “grpc-status-details-bin” header (a special binary header containing error details that accompany the gRPC status) that uses padding.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.