ServerWritableStreamImpl::end breach the SOLID
Open
package: @grpc/grpc-js
package: grpc
- Dominant language
- TypeScript
- Stars
- 4.8k
- Forks
- 716
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 10
Description
It look code at below link is breach Barbara Liskov's substitution principle:
https://github.com/grpc/grpc-node/blob/db39ba245c3872e3b5d57a296d744cce63e23bf2/packages/grpc-js/src/server-call.ts#L234
It overrides behaviour of method 'end'
https://nodejs.org/api/stream.html#writableendchunk-encoding-callback
Contributor guide
Assessment
This issue has not been assessed yet.