grpc / grpc/grpc-node

Please add support for server compression

Open
#1,823 10 comments 8 reactions 1 assignee Claimed by @murgatroid99 View on GitHub
feature request package: @grpc/grpc-js
Dominant language
TypeScript
Stars
4.8k
Forks
716
Avg merge
2d 3h
Merged PRs (30d)
10

Description

### Is your feature request related to a problem? Please describe.
Not really, other than the fact that I cannot migrate my server from `grpc` to `@grpc/grpc-js` until `@grpc/grpc-js` supports compression. Our clients (millions of them...) send messages compressed (gzip) in a bi-directional stream. Also, `@grpc/grpc-js` does not return an `UNIMPLEMENTED` error when the client sends the `grpc-compression` header with a value other than `identity`...

### Describe the solution you'd like
Something along the lines of what is implemented in https://www.npmjs.com/package/grpc-server-js (I just perused through that code and found out that they already support compression) It also looks like this has been partially implemented in `compression-filter.ts` already... And I see a lot of `TODO(cjihrig)` in the code to point to the areas that should be modified.

### Describe alternatives you've considered
Keep using the `grpc` package for now, even though it explicitly says that it has been deprecated. Compression is a major feature IMO, so maybe the deprecation was a little hasty?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.