grpc / grpc/grpc-java

Tracking Issue for setOnCloseHandler being Experimental

Open
#8,467 3 comments 0 reactions 0 assignees View on GitHub
experimental API
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

To resolve issue #5895 PR #8452 has been created that adds new `ServerCallStreamObserver.setOnFinishHandler(...)` method.
The handler is called by `Listener.onComplete` _when the call is **finished** correctly from the server's point of view: either `onCompleted()` or `onError(Throwable)` has been called, all the messages and trailing metadata have been put on the wire and the stream has been closed_.

Several names were proposed for the handler:
- `onCompleteHandler` : derives name from `Listener`'s method but causes confusion with `StreamObserver.onCompleted()`
- `onSuccessHandler` : my initial idea, yet also confusing as it can be called also after `StreamObserver.onError(...)`
- `onFinishHandler` : current approach, matches well the verb from method's javadoc
- `onFinalizeHandler` : would also probably do well

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.