grpc / grpc/grpc-java

Consider adding @Nullable / @Nonnull annotations to generated services

Open
#4,724 17 comments 9 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

Please answer these questions before submitting your issue.

### What version of gRPC are you using?

1.13.2

### What did you expect to see?

It would be very helpful for those of us implementing *ImplBase classes in Kotlin if the parameters of generated `rpc` methods were annotated with `@javax.annotation.Nonnull` as it gives tooling a hint that the signature of an `override` should use the non-nullable form of the parameter types.

Minor, but would make implementing services in Kotlin that bit more seamless.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.