grpc / grpc/grpc-java

StreamTracer should be mockable

Open
#4,658 3 comments 0 reactions 0 assignees View on GitHub
code health
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

#3305 put DoNotMock on StreamTracer saying that the mocks are not thread-safe. But [mockito claims they are](https://github.com/mockito/mockito/wiki/FAQ#is-mockito-thread-safe), except for stubbing and verify methods. We need to figure out where the discrepancy is and either file a bug against Mockito or let the StreamTracer be mocked.

I discovered this as part of removing DoNotMock for #4452. For my changes, I left things as-is, but I found the documentation I wrote to be questionable.

CC @carl-mastrangelo

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.