grpc / grpc/grpc-java

Extracting all keys from CallOptions objects

Open
#4,251 4 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

In [gax-java](https://github.com/googleapis/gax-java/), we would like to be able to merge two [CallOptions](https://github.com/grpc/grpc-java/blob/master/core/src/main/java/io/grpc/CallOptions.java) objects together. We are able to partially implement this merging of `CallOptions` using the `with` methods available on `CallOptions`, such as here: https://github.com/googleapis/gax-java/blob/master/gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcCallContext.java#L223

However, currently it is not possible to extract the full set of custom options from the `CallOptions` object, which means we are not able to create a merged set of custom options.

Is there any way to extract the full set of keys from a `CallOptions` object currently? If not, would grpc-java consider adding either (a) a `merge()` method on `CallOptions`, or (b) a way to extract the complete set of custom options, to allow us to implement merging?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.