grpc / grpc/grpc-java

DelayedStream.setStream() should cancel the provided stream if not using it

Open
#1,537 4 comments 0 reactions 1 assignee Claimed by @zhangkun83 View on GitHub
code health
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

If `cancel()` or `setStream()` was previously called then `setStream()` throws away the stream argument. It should `cancel()` the stream to make sure resources are freed, although I think only DelayedClientTransport benefits.

This should not be done until after #1536. I don't know if OkHttp suffers a similar problem. If so, we may want to revisit whether it makes sense to allow streams to be cancelled before `start()`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.