grpc / grpc/grpc-java

BlockingClientCall.write should block after writing the message

Open
#12,074 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

When a program calls `BlockingClientCall.write`, it's already done the work necessary generate a message. Little is lost then by immediately serializing the message and preparing it for transmission once the flow control window opens up. `BlockingClientCall.write`, however, waits for the call to be ready before taking any steps to send the message. I propose to move the blocking to after calling `ClientCall.sendMessage`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.