grpc / grpc/grpc-java

Include network four-tuple for connections in io.grpc.ChannelLogger logs

Open
#10,936 0 comments 0 reactions 1 assignee Claimed by @ejona86 View on GitHub
enhancement
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

We can't include them in each log message, because we simply don't know the values much of the time. But specifically for the transportReady and transportShutdown notifications, it seems we can plumb it without synchronization. We can add methods to ManagedClientTransport to get the local/remote addresses, maybe just as a `getAttributes()` method.

There's probably some status messages that would also be useful to include the four-tuple, but it may be hard to track them. Maybe we could include it in the DEADLINE_EXCEEDED message we generate.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.