grpc / grpc/grpc-java

Support of `dns:name` URIs

Open
#10,824 8 comments 0 reactions 0 assignees View on GitHub
docs enhancement
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

As it currently stands, the URI validation and parsing for `dns` schema in grpc-java is in contradiction of ~~both RFC-4501 and~~ (not relevant really) core gRPC specs by rejecting `dns:name`-type URIs (no slash). This generates discrepancies between different gRPC implementations and is generally problematic. [Currently we have 6 (yes, literally six) competing standards as to what URIs are allowed, none of which are actually aligned, and all of them are "official" in some way.](https://github.com/grpc/grpc/issues/35539#issuecomment-1889957866) The only thing that's missing for grpc-java to be a strict superset here (and thus reduce the incompatibilities and confusion) is to have `dns:name` allowed ~~as per RFC-4501 spec~~ (ditto).

A fully backwards-compatible solution would be to change https://github.com/grpc/grpc-java/blob/master/core/src/main/java/io/grpc/internal/DnsNameResolverProvider.java#L56 to allow any reasonable/valid ~~RFC-4501-compliant~~ (ditto) URI to be accepted. Code-wise, it's trivial, has no parsing ambiguities and has no negative impact on the existing code solutions.

### Describe the solution you'd like
`dns:name` would be included as valid ~~, RFC-4501-type URIs would be better~~ (ditto) and supported, confusion and discrepancies would be reduced.

### Additional context
https://github.com/grpc/grpc/issues/35539 & https://github.com/grpc-ecosystem/grpc-spring/issues/1024
If a PR is needed, I'll gladly do it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.