Inverted if condition in StreamWrapper.DisposeAsync
Open
- Dominant language
- C#
- Stars
- 4.5k
- Forks
- 836
- Avg merge
- 6d 3h
- Merged PRs (30d)
- 7
Description
Just spotted while reading code, not sure if it's currently being used anywhere.
https://github.com/grpc/grpc-dotnet/blob/f4148e8833dcedf8ef13b0817c0fc1c036921f7e/src/Grpc.Net.Client/Balancer/Internal/StreamWrapper.cs#L106-L112
Contributor guide
Research direction
Start at src/Grpc.Net.Client/Balancer/Internal/StreamWrapper.cs lines 106-112 and inspect DisposeAsync and its surrounding callers to confirm the reported inverted condition. Compare the condition with the intended disposal path, then run the relevant Grpc.Net.Client tests; done means the condition is corrected and the tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100