grpc-ecosystem / grpc-ecosystem/grpc-spring

Add example for sleuth/brave integration

Open
#264 9 comments 0 reactions 0 assignees View on GitHub
examples help wanted
Dominant language
Java
Stars
3.7k
Forks
858
PR merge metrics
No merged PRs in 30d

Description

This is a usage question.

In the [Sleuth docs](https://cloud.spring.io/spring-cloud-sleuth/spring-cloud-sleuth.html#_grpc) for gRPC, they mention two variants. First one uses `io.github.lognet:grpc-spring-boot-starter` and `io.zipkin.brave:brave-instrumentation-grpc` and clients must use `SpringAwareManagedChannelBuilder`. In the second variant, nothing is said other than _"Grpc Spring Boot Starter automatically detects the presence of Spring Cloud Sleuth and brave’s instrumentation for gRPC and registers the necessary client and/or server tooling."_

There doesn't seem to be any relation between these projects, and are maintained by different people. `yidongnan/grpc-spring-boot-starter` doesn't seem to use `SpringAwareManagedChannelBuilder` anywhere. Should it? Also, does it need `io.zipkin.brave:brave-instrumentation-grpc` to work?

Perhaps the owners of the two projects should discuss merging them. It seems like a waste of time to develop two parallel projects for the same purpose.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.