grpc-ecosystem / grpc-ecosystem/grpc-httpjson-transcoding

This project is using internal-only protobuf APIs that may soon change namespaces or disappear.

Open
#35 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
178
Forks
39
PR merge metrics
No merged PRs in 30d

Description

Hi there, I work on protobufs. I noticed your project is using APIs from `google/protobuf/util/internal`:

```
#include "google/protobuf/util/internal/json_stream_parser.h"
#include "google/protobuf/util/internal/object_writer.h"
```

https://github.com/grpc-ecosystem/grpc-httpjson-transcoding/blob/master/src/json_request_translator.cc#L23-L24

These APIs have "internal" in the include path, and are not for end-user consumption. We will likely be removing these soon, or at least changing their namespace to make it even clearer that these APIs are not for users.

This came to my attention because of this PR in our repo:

https://github.com/protocolbuffers/protobuf/pull/5939#issuecomment-524411767

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.