growthbook / growthbook/cli

Empty-object request bodies marked required force a meaningless --body-param '{}' (spec/back-end)

Open
#53 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1
Forks
0
Avg merge
1d 5h
Merged PRs (30d)
18

Description

**Behavior:** eight revision ops (`recall-review`, `reopen`, `discard`, `undo-review`, `delete-log-entry` across feature/config revisions, v1+v2) spec an empty-object request body with `required: true`, so the CLI demands an opaque `--body-param` that must be `'{}'`. The commands' own generated doc examples fail with `missing required flag: --body-param`.

**Carried fix:** overlay marks the eight request bodies `required: false` (PR #48). Express's json parser defaults an absent body to `{}`, so the server's `z.object({})` still validates — verified live (recall-review with no body reaches the server and returns the correct business validation).

**Retire when:** the back-end marks these request bodies optional (or drops them) at source in the Zod validators, after which the overlay entries can be dropped.

Ops: postFeatureRevisionDiscard, postFeatureRevisionDiscardV2, postFeatureRevisionRecallReviewV2, postFeatureRevisionReopenV2, postFeatureRevisionUndoReviewV2, deleteFeatureRevisionLogEntryV2, postConfigRevisionRecallReview, postConfigRevisionReopen.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the overlay entries for the eight listed revision operations and compare them with PR #48. Verify that generated command examples no longer require --body-param for an empty object, then confirm the overlay can be retired once the back-end request bodies are optional or removed at the source.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, openapi
Domain
api, cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.