griffithlab / griffithlab/pVACtools
Calculate reference proteome similarity when running `generate_protein_fasta` commands
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 188
- Forks
- 81
- Avg merge
- 9d 17h
- Merged PRs (30d)
- 6
Description
#450 adds calculation of reference proteome similarity metrics to the main pVACtools pipelines. We should also add them to the individual generate_protein_fasta commands.
This needs to be made configurable because the underlying modules are also used by the generate_combined_fasta steps in the main lib/pipeline.py module. We don't want the proteome similarity metrics to be calculate here because they aren't needed and will add a lot of overhead. This could be achieved by adding a --no-metrics flag to to the commands, which can then be set when calling the modules in generate_combined_fasta. This would also allow us to make the calculation of manufacturability metrics optional for these commands. Manufacturability metrics are currently always run and, thus, get extraneously generate in generate_combined_fasta where we immediately deleted them.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the individual generate_protein_fasta commands and the generate_combined_fasta steps in lib/pipeline.py, then inspect how the underlying modules calculate proteome similarity and manufacturability metrics. The work is done when both metrics can be controlled for the individual commands without adding unnecessary calculations or generated files during the combined FASTA pipeline.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100