gridap / gridap/GridapSolvers.jl

missing `numerical_setup!` for `IterativeLinearSolverNS`

Open
#60 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
43
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Hi @JordiManyer , I think the implementation of the function `numerical_setup!` is missing for `IterativeLinearSolverNS`. When solving a transient problem using an iterative solver, this function is called here: https://github.com/gridap/Gridap.jl/blob/9079dd1ac56da9ca5f6d8d3952d69caa6c014fa4/src/ODEs/StageOperators.jl#L280

I tried to have a look at what is the problem and how to solve it, but since this is a wrapper of many solvers, before implementing anything I would like to ask if this is indeed missing or am I doing something wrong. Could you take a look at it?

Thank you!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.