gridap / gridap/GridapSolvers.jl

Error in SchurComplementSolvers.jl

Open
#41 1 comment 1 reaction 1 assignee Claimed by @JordiManyer View on GitHub
Dominant language
Julia
Stars
43
Forks
5
PR merge metrics
No merged PRs in 30d

Description

I think there is an error in this line: https://github.com/gridap/GridapSolvers.jl/blob/0e626022447647d476d7d3f2f44c7b6e09757136/src/LinearSolvers/SchurComplementSolvers.jl#L65

To my understanding it should be something like:

```
copy!(bp,y_p); mul!(bp,C,x_u,-1.0,1.0) # bp = y_p - C*(A^-1 y_u)
```

I was having wrong results in my application and this modification gives the good solution.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.