gridap / gridap/Gridap.jl

`finalize_coo!` does not check and add diagonal entries as claimed in the docstring

Open
#361 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
879
Forks
119
Avg merge
6d 3h
Merged PRs (30d)
4

Description

The following implementation of `finalize_coo!` does nothing while the docstring says that this function should "Check and insert diagonal entries in COO vectors if needed." When is it "needed"?
https://github.com/gridap/Gridap.jl/blob/28dd80b2ad2c099a85c030f4d6670552f8a2fdb5/src/Algebra/SparseMatrixCSC.jl#L23

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.