`==` on `Value`s of different shape misbehaves
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 48
- Forks
- 14
- Avg merge
- 4h 14m
- Merged PRs (30d)
- 1
Description
Encode.objectproperties- https://github.com/elm/core/issues/945
Note: It is discouraged to actively call == on js Json.Encode/Decode.Values:
- https://discourse.elm-lang.org/t/function-equality/7538/24
- https://package.elm-lang.org/packages/elm/core/latest/Basics#equality
Should compile-time constraints on == be introduced, Values would be disallowed from being compared, allowing these cases could be ignored.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no source file, test, or entry point. Start by reviewing the linked elm/json and elm/core issues, then locate Gren's equality handling for Json.Encode/Decode.Value and reproduce comparisons between differently shaped Values; done means the behavior is defined and covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100