gregnb / gregnb/mui-datatables

on custom filters, chip always displays

Open
#816 10 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
JavaScript
Stars
2.7k
Forks
906
PR merge metrics
No merged PRs in 30d

Description

When there are custom filters the chip always displays. When the X on the chip is clicked the filter does reset, but the chip remains.

Thank you for the awesome component! ❤️

## Expected Behavior
I expect the chip to disappear when its X is clicked with custom filters.

## Current Behavior
The chip does not disappear when its X is clicked with custom filters.

## Steps to Reproduce (for bugs)
Use column options such as below:
```
const options = {
filter: true,
filterList: filterText,
filterType: 'custom',
customFilterListRender: v => 'Filter On',
filterOptions: {
names: filterText,
logic: filterOut,
display: Display,
},
sort: false,
}
```
## Your Environment
| Tech | Version |
|--------------|---------|
| Material-UI | @material-ui/core@3.9.2 |
| MUI-datatables | mui-datatables@2.7.0 |
| React | react@16.8.3 |
| browser | chrome 75.0.3770.142 |
| platform | mac |

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.