gregnb / gregnb/mui-datatables

Set max-width for Filters

Open
#410 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.7k
Forks
906
PR merge metrics
No merged PRs in 30d

Description

The filters selector is too big on desktop. It might be better to have a `max-width` set.

## Expected Behavior
I expect the width of Filters to be similar to Show Columns.

## Current Behavior
The filters selector is too big on desktop. The typography or maybe just color / capitalization is also different.

## Steps to Reproduce (for bugs)
link to a live example: [specific example](https://kotobago.com/?states=%21_N%7E&lengths=%210%7E&page=DEST_PICKER)

Here is a screenshot of how it is [with default 2.0.0-beta-54](https://imgur.com/a/7Uc52gS)

and [with max-width: 500px set](https://imgur.com/a/5lizsjH). but it would probably be best to do something more responsive but I'm not sure how you made the other things responsive so

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the live example and screenshots, then locate the Filters and Show Columns UI and compare their desktop sizing and typography. Check how the existing controls respond at different widths. Done means Filters has a responsive width comparable to Show Columns without the oversized desktop selector.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.