gregnb / gregnb/mui-datatables

Bad typing on MUIDataTableOptions renderExpandableRow - rowData

Open
#2,031 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.7k
Forks
906
PR merge metrics
No merged PRs in 30d

Description

Bad typing on MUIDataTableOptions renderExpandableRow - rowData param
rowData is NOT a string array, it is an object similar to React.Component<{text: string}>

## Expected Behavior

rowData is NOT a string array, it is an object like React.Component<{text: string}>

## Current Behavior

rowData is set to a string array

## Steps to Reproduce (for bugs)

1. Check MUIDataTableOptions type
2. Check renderExpandableRow
3. Check rowData param

## Your Environment

| Tech | Version |
|--------------|---------|
| Material-UI | |
| MUI-datatables | |
| React | |
| browser | |
| etc | |

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the MUIDataTableOptions type and inspect the renderExpandableRow rowData parameter. Compare its current string-array typing with the object-shaped rowData described in the issue. Done means the declaration reflects the actual rowData shape and the project’s type checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.