gregnb / gregnb/mui-datatables

Is there a plan of migration to material-ui v5?

Open
#1,513 23 comments 14 reactions 0 assignees View on GitHub
material ui 5.0
Dominant language
JavaScript
Stars
2.7k
Forks
906
PR merge metrics
No merged PRs in 30d

Description

The issue is when I updated the Material-UI library to the latest version I found out that MUI-datatables doesn't support the Material-UI library v5.

Updated Material-UI libs to the following versions:
* "@material-ui/core": "5.0.0-alpha.9",
* "@material-ui/icons": "5.0.0-alpha.7",
* "@material-ui/lab": "5.0.0-alpha.9",
* "@material-ui/pickers": "^4.0.0-alpha.12",
* "@material-ui/styles": "5.0.0-alpha.8",

## Expected Behavior
No errors and crashed on the Table filter action.

## Current Behavior

There are errors and crashed on the Table filter action press.

I guess this issue is due to Material-UI library new version - The onE* transition props were removed. Use TransitionProps instead. https://github.com/mui-org/material-ui/releases/tag/v5.0.0-alpha.7
Screenshot 2020-09-11 at 17 06 58
Screenshot 2020-09-11 at 17 07 20
Screenshot 2020-09-11 at 17 07 20

## Steps to Reproduce (for bugs)

1. update material-ui and it's dependant libs to the latest
2. fix all breaking changes in your app
3. go to the page you have a table based on MUI-datatables
4. suppose it has passed data inside the table and **filter** option is true
5. click on the Filter icon button
[](url)

## Your Environment

| Tech | Version |
|--------------|---------|
| Material-UI | 5.0.0-alpha.9 |
| MUI-datatables | 3.4.1 |
| React | 16.13.1 |
| browser | Chrome (latest) |
| etc | |

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the filter action with MUI-datatables 3.4.1, React 16.13.1, and Material-UI 5.0.0-alpha.9 using the reported dependency updates. Investigate the errors caused by removed onE* transition props and determine the migration scope. Done means the table filter action works without errors or crashes under Material-UI v5.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.