gregnb / gregnb/mui-datatables

MUIDataTableToolbar-root @media print setting might have negative impact on printing of table?

Open
#1,370 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.7k
Forks
906
PR merge metrics
No merged PRs in 30d

Description

![image](https://user-images.githubusercontent.com/25733358/85428137-9e2d1100-b531-11ea-8bcd-0002e5bddb2a.png)

## Expected Behavior
This area should render in print outs, if I'm not mistaken the toolbar has a left and right side and the left is reserved for the table's title?

## Current Behavior
The display none is applied to the MUIDataTableToolbar so the @media print change is making the table render without a title section. I can understand not wanting to see the actions menu, if that is the case I would suggest applying the css to those sections and do visibility hidden rather than display none since visibility will persist the empty space.

| Tech | Version |
|--------------|---------|
| Material-UI | 4.9.1 |
| MUI-datatables | 3.0.1 |

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the MUIDataTableToolbar print-media styling and review the issue screenshot and expected behavior. Check the table in print preview to confirm whether the title area remains visible while action controls are handled appropriately; done means the toolbar title is preserved in printed output.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.