gregnb / gregnb/mui-datatables

Filter dialog, column vs row options ordering

Open
#1,137 2 comments 0 reactions 1 assignee Claimed by @Dragomir-Ivanov View on GitHub
new feature
Dominant language
JavaScript
Stars
2.7k
Forks
906
PR merge metrics
No merged PRs in 30d

Description

Hi, I am migrating from v2.0.0-alpha to the current 2.13.3, but what bugs me is that in the Filtering dialog options have been ordered in a column fashion, but in 2.13.3 they are ordered in rows. This looks really ugly and messy, in spite of taking less space.

Is that intentional, and can we add an option this behavior to be chosen, say adding another option
`filterDisplay: enum('rows':'columns')`

Can we add close button `X` at upper right corner of the filter dialog. On mobile devices this dialog occupies almost whole screen and clicking outside of it is really hard.

If these changes seem reasonable, I can step in and make PRs. Thanks!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.