greenelab / greenelab/PathCORE-T

permutation test method `network_edges_permutation_test` should return both the significant edges and the final network.

Open
#4 0 comments 0 reactions 1 assignee Claimed by @kathyxchen View on GitHub
bug
Dominant language
Python
Stars
4
Forks
3
PR merge metrics
No merged PRs in 30d

Description

In the event that we [do not specify any filepaths to output this method's results](https://github.com/greenelab/PathCORE/blob/master/pathcore/network_permutation_test.py#L43), we should return a tuple containing both the edges significant based on the permutation test and the network itself.

In addition or alternatively, the [CoNetwork class's `to_dataframe` method](https://github.com/greenelab/PathCORE/blob/master/pathcore/network.py#L458) should have a parameter that allows for only the edges considered significant after the permutation test (each edge object would then have a `significant` boolean parameter) to be included in the dataframe. This would remove the need to pass in a `whitelist` parameter every time.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.