greatscottgadgets / greatscottgadgets/hackrf

minor issue: hackrf_max2837_read endianness?

Open
#778 8 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

bug software
Dominant language
C
Stars
8.1k
Forks
1.7k
Avg merge
15d 7h
Merged PRs (30d)
1

Description

I was reading the code and found that in hackrf_max2837_read:

https://github.com/mossmann/hackrf/blob/e93d70eddc6a2ed95af252c5acb7022fabba642f/host/libhackrf/src/hackrf.c#L700-L709

The value is returned straight from the USB transfer. Shouldn't it be converted to little endian?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.