graze / graze/unicontroller-client

BinaryData length possibly incorrect

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
PHP
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

The client is using `strlen` to measure binary data length, this returns the number of bytes. The printers appear to use the actual number of characters, regardless of their size.
As the number of bytes will always be >= the number of characters, this doesn't appear to cause any issues.
Investigate using `mb_strlen`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.