gray-mueller / gray-mueller/food-delivery-clone-app-using-react

Security Vulnerabilities in Multivendor Admin - Username Gap and Negative Values in Restaurant Parameters

Open
#394 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
When creating a new restaurant in the multivendor admin system, there are serious security vulnerabilities present. The system allows the acceptance of gaps in usernames and negative values in crucial parameters such as delivery time, minimum order, and sales tax, compromising the system's integrity.

To Reproduce
Steps to reproduce the behavior:

Log in to the multivendor admin system.
Navigate to the "Create New Restaurant" section.
Submit the form with a gap in the username field.
Observe that the system accepts the submission without displaying any error messages.
Submit the form with negative values for delivery time, minimum order, and sales tax.
Note that the system also accepts these negative values without proper validation.
Expected behavior

The system should disallow the submission of the form with gaps in the username field, displaying a clear error message.
The system should validate and reject the submission if negative values are provided for delivery time, minimum order, and sales tax, displaying appropriate error messages.
Screenshots
image

Desktop:

Browser: chrome

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the multivendor admin system's Create New Restaurant form using a spaced username and negative delivery time, minimum order, and sales tax values. Locate the form's validation entry point and verify the existing error-display behavior. Done means invalid submissions are rejected with clear errors for each reported input.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.