gravitational / gravitational/shared-workflows

allow overwriting flaky test detector timeout and/or count by admin

Open
#429 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
7
Forks
4
Avg merge
19h 53m
Merged PRs (30d)
5

Description

The bot currently supports excluding flaky tests to allow merging changes that are timing out:

/excludeflake *

However, occasionally when using diff testing and touching a lot of tests, the 100 count can easily exceed the default 10m timeout value even if the tests may not be flaky. This is especially the case when running on underpowered CI instances.

It would be quite handy if on a exception basis, an admin could overwrite the count and/or timeout when a change is otherwise sound.

Perhaps something like

/flaketimeout 20m
/flakeattempts 50

Ignoring the flaky test results could potentially be a way to cover for tests that are too slow AND introduce flakyness that will surface later on.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the bot implementation of /excludeflake and its default timeout and count handling; done means admins can use validated timeout and attempt overrides without weakening the existing flaky-test safeguards.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, go
Domain
ci-cd, devops, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.