graphql / graphql/graphql-spec

Improve HTML generation robustness in build.sh

Open
#1,220 1 comment 0 reactions 0 assignees View on GitHub
🐝 Process
Dominant language
JavaScript
Stars
14.6k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Current `build.sh` script uses direct string concatenation to construct `public/index.html`, incorporating data from Git tags and commit metadata. While the environment is managed by trusted editors, this approach is susceptible to HTML injection if malformed tags or commit messages are introduced into the build pipeline.

Adopting a more robust templating approach or ensuring proper escaping for HTML-sensitive characters would improve the long-term reliability and security of the specification's deployment process. I noticed this while reviewing the internal build tools for potential editorial improvements.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.