graphql / graphql/graphiql

[graphiql] Find / Find and Replace menu is still visible when dismissed

Open
#4,093 2 comments 1 reaction 0 assignees View on GitHub
bug graphiql
Dominant language
TypeScript
Stars
16.9k
Forks
1.9k
Avg merge
22h 45m
Merged PRs (30d)
70

Description

### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current Behavior

This screenshot show the find menu after closing it.

Image

### Expected Behavior

This is how it should be displayed

Image

### Steps To Reproduce

1. Hit `ctrl + F` to open the find menu or `ctrl + h` to open the find and replace menu
2. Click to `X` icon to close or hit `Esc`

### Environment

* GraphiQL Version: 5.2.0
* OS: Windows
* Browser: Firefox / Chrome

### Anything else?

This line of code is the issue:

https://github.com/graphql/graphiql/blob/0d9e51aa6452de1a1dee1ff1d1dae6df923f389f/packages/graphiql-react/src/style/editor.css#L29

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.