graphql / graphql/graphiql

[vscode-graphql-syntax] Syntax for markdown should re-use js embed rules

Open
#3,151 2 comments 0 reactions 0 assignees View on GitHub
bug vscode-graphql-syntax
Dominant language
TypeScript
Stars
16.9k
Forks
1.9k
Avg merge
22h 45m
Merged PRs (30d)
70

Description

### Current Behavior
Currently, we have a markdown implementation that applies it's own logic for detecting graphql tags inside markdown blocks.

In LSP terms, that is a three times embedded language, haha! Vue and Svelte, markdown, all are examples of languages that embeds js/ts, which users expect to highlight embedded markdown for.

### Expected Behaviour

Any improvements to the javascript implementation should happen for markdown. We just need to tweak the grammar json files to do so.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.