graphql / graphql/dataloader

[BUG] Use caution with `jest.useFakeTimers()`

Open
#339 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
13.4k
Forks
518
Avg merge
2d 4h
Merged PRs (30d)
2

Description

Just spent ages debugging why our tests were breaking when using `DataLoader` and eventually discovered that since we were using `jest.useFakeTimers()` it was never resolving the batch.
Would be good to have some kind of warning about this in the readme.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.