CacheMap.get calls should await the promised value
Open
- Dominant language
- JavaScript
- Stars
- 13.4k
- Forks
- 518
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 2
Description
https://github.com/graphql/dataloader/blob/015a94c8db0b4974838a312634c12a2c5eb3d056/src/index.js#L88-L97
Seems like this prevents the use of async calls to centralized caches in it's current implementation since the returned promise will be 'Truthy' even if it resolves with a cache miss (null, undefined).
Wondering if there is a design reason for this, or a PR is welcome ?
Contributor guide
Assessment
This issue has not been assessed yet.