graphql-python / graphql-python/graphql-core-legacy
Violation of Liskov Substitution Principle
Open
- Dominant language
- Python
- Stars
- 372
- Forks
- 175
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/graphql-python/graphql-core/blob/3ba7f9218bca7a039b109b103cf57b1511d970c7/graphql/execution/executor.py#L704
Above referenced line violates Liskov Substitution Principle when used with at least Graphene-Django and the underlying model is itself a subclass of aDjangoObjectType.Meta.model class.
A popular variant of this violation is use of django-polymorphic, which is quite prevalent. However, we're talking basic Python here.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.