graphql-python / graphql-python/graphene

How to address inheritance chain changes between Graphene 2 and 3?

Open
#1,592 0 comments 0 reactions 0 assignees View on GitHub
🐛 bug
Dominant language
Python
Stars
8.2k
Forks
818
PR merge metrics
No merged PRs in 30d

Description

* **What is the current behavior?**

In order for us to have consistent IDs and unique IDs for all our entities we made all entities were inheriting from this class:

```python
class ObjectTypeWithID(ObjectType):
id = ID(required=True, description="globally unique identifier")
entity_id = String(required=True, description="identifier for the entity")
model_id = String(required=True, description="identifier for the entity model")

def __init__(self, id):
print('!!!ObjectTypeWithID.__init__')
self.id = generate_global_id(self.__class__.__name__, id)
self.entity_id = id
self.model_id = id

# usage
class User(ObjectTypeWithID)
def __init__:
super().__init__(user_id)
```

This worked fine in Graphene 2.x but once we tried to upgrade to Graphene 3.x it seems like `super().__init__` does not trigger `ObjectTypeWithID`

I checked the mro and I noticed there's now InterObjectType between User and it's parent ObjectTypeWithID and I suspect it's getting in the way when call `super()`

`user.__class__.__mro__` in Graphene 3.x
```python
(
>,
.InterObjectType'>,
>,
.InterObjectType'>,
,
.InterObjectType'>,
,
,
)
```

`user.__class__.__mro__` in Graphene 2.x
```python
(
>,
>,
,
,
,

)
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.