graphql-python / graphql-python/graphene

Graphene v3 ignores mixin/multiple inheritance methods

Open
#1,292 3 comments 1 reaction 0 assignees View on GitHub
🐛 bug
Dominant language
Python
Stars
8.2k
Forks
818
PR merge metrics
No merged PRs in 30d

Description

* **What is the current behavior?**
* **If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem** via
a github repo, https://repl.it or similar.

We use mixins to override `__init__` (and other methods) for certain types. However, Graphene 3 does not seem to handle this python multiple-inheritance correctly. It calls the default `graphene.ObjectType.__init__` instead of the custom `__init__` method defined on the mixin.

A minimal example:
```python
import graphene

class Mixin:
def __init__(self):
print("Calling Mixin.__init__()...")
super().__init__(
value="mixin value"
)

class Thing(Mixin, graphene.ObjectType):
value = graphene.String()

class TestQuery(graphene.ObjectType):
test = graphene.Field(Thing)
resolve_test = lambda parent, info: Thing()

schema = graphene.Schema(query=TestQuery)
print(schema.execute(
"""
{
test {
value
}
}
"""
))
```

In Graphene 2, this works correctly, printing the result `ExecutionResult(data={'test': {'value': 'mixin value'}}, errors=None)` and the statement `Calling Mixin.__init__()...`. However, in Graphene 3, we get the result `ExecutionResult(data={'test': {'value': None}}, errors=None)`, and `Calling Mixin.__init__()...` never prints.

* **What is the expected behavior?**

- `Mixin.__init__` should be called.
- The result of the query should be `ExecutionResult(data={'test': {'value': 'mixin value'}}, errors=None)`

* **What is the motivation / use case for changing the behavior?**
Maintain functionality of graphene 2, enable use of multiple inheritance/mixins

* **Please tell us about your environment:**

- Version: `graphene==3.0b6`
- python `3.6.8`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.