graphql-python / graphql-python/graphene

Request-level middleware

Open
#1,117 4 comments 5 reactions 1 assignee Claimed by @erikwrede View on GitHub
wontfix
Dominant language
Python
Stars
8.2k
Forks
818
PR merge metrics
No merged PRs in 30d

Description

I'm using Graphene with Django, and I have a middleware that checks user auth token. I'm having an issue with the middleware being executed at the field-level. Each field resolution triggers a call to check user's token in my case.

Any suggestions to improve this? Any plans for supporting request-level middleware?

I have some idea:
1. Move auth checking into a Django middleware, but that means any exception raised will not be serialized into GraphQLResponse.
2. Add a flag `is_authenticated` into `info.context` object, if the value of `info.context.is_authenticated` is True, skip the middleware by calling `next()`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.