graphql-python / graphql-python/graphene-sqlalchemy

Update Examples Documentation to Cover Dataloaders / Batching

Open
#332 0 comments 3 reactions 0 assignees View on GitHub
:book: documentation enhancement
Dominant language
Python
Stars
985
Forks
223
PR merge metrics
No merged PRs in 30d

Description

Though there is some information on how to implement dataloaders in [test_batching.py](https://github.com/graphql-python/graphene-sqlalchemy/blob/master/graphene_sqlalchemy/tests/test_batching.py), the sample code in the [examples](https://github.com/graphql-python/graphene-sqlalchemy/tree/master/examples) directory lacks examples of how to do it.

My original code is based on that in the examples directory. I have been trying to use [test_batching.py](https://github.com/graphql-python/graphene-sqlalchemy/blob/master/graphene_sqlalchemy/tests/test_batching.py) to get batching working without much success. If I got it to work I would have submitted a PR.

This is a significant new feature for the code base and it would be excellent to have definitive examples in the repo.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.