graphql-python / graphql-python/graphene-sqlalchemy

Better approach to `is_mapped_class`

Open
#124 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
985
Forks
223
PR merge metrics
No merged PRs in 30d

Description

`sqlalchemy.orm.class_mapper` relies on `sqlalchemy.orm.configure_mappers` to have been called - either explicitly or implicitly by attempting to interact with the mapper. This means that `graphene_sqlalchemy.utils.class_mapper` forces a call to `configure_mappers` – which in turn throws an error unless every model referenced in a deferred callable (i.e. `user = relationship('User')`) has already been discovered.

However, there is another way to determine if a class is a mapper without forcing `configure_mappers`. The recipe is this:

```python
from sqlalchemy.orm import Mapper
from sqlalchemy.exc import NoInspectionAvailable

def is_mapped_class(cls):
'''modified from graphene_sqlalchemy/types.py '''
try:
return isinstance(inspect(cls), Mapper)
except NoInspectionAvailable:
return False
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.