graphql-python / graphql-python/graphene-django
graphene-django v3 has broken Data Loaders
- Dominant language
- Python
- Stars
- 4.4k
- Forks
- 760
- PR merge metrics
- No merged PRs in 30d
Description
Hi there!
Data loaders used to work with `graphene-django`, there is a perfectly maintained example of it here https://github.com/ngshiheng/django-graphene-starter .
They don't work anymore after updating `graphene` and `graphene-django` to v3, even after following the new graphene docs [here](https://github.com/graphql-python/graphene/pull/1190/files).
According to these docs though, they seem to work in `graphene` v3, so the only thing left to do is make `graphene-django` compatible with that behaviour.
It seems that there is work ongoing on trying to make it function again in `graphene-django` (https://github.com/graphql-python/graphene-django/pull/1256 and https://replit.com/@jkimbo/Graphene-async#main/schema.pyhttps://replit.com/@jkimbo/Graphene-async#main/schema.py @fabienheureux @jkimbo)
I have two questions:
1) Is my diagnostic right or have I missed something? Did `graphene-django` v3 really break this? I would really like to use DataLoader with `graphene-django` v3 as it is a much better solution than `graphene-django-optimizer`, but am stuck right now.
2) Is the work on solving the issue ongoing, and if yes do you have an approximative ETA? This is quite critical for our business 😬 I would be really happy to help on this issue if needed! 🙂
PS: @syrusakbary, is this on your radar? The support of DataLoader with `aiodataloader` seems really nice but it's a big issue for the community if it works in `graphene` but not in `graphene-django` 😅
Thanks!
Contributor guide
Assessment
This issue has not been assessed yet.