graphql-python / graphql-python/gql-next

Issues with DateTime ISO fields

Open
#29 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
78
Forks
6
PR merge metrics
No merged PRs in 30d

Description

when i run `gql_run` and the `renderer_dataclasses.py` encounters a DateTime field it generates a field:

`var_name: datetime = None`

when I run a query that returns a datetime object I get the following error:

```
File "/Users/jasper/Documents/test/test-graph-python-client/env/lib/python3.7/site-packages/dataclasses_json/core.py", line 220, in _decode_generic
res = _get_type_cons(type_)(xs)
File "/Users/jasper/Documents/test/test-graph-python-client/env/lib/python3.7/site-packages/dataclasses_json/core.py", line 260, in
for x in xs)
File "/Users/jasper/Documents/test/test-graph-python-client/env/lib/python3.7/site-packages/dataclasses_json/core.py", line 165, in _decode_dataclass
infer_missing)
File "/Users/jasper/Documents/test/test-graph-python-client/env/lib/python3.7/site-packages/dataclasses_json/core.py", line 179, in _decode_dataclass
dt = datetime.fromtimestamp(field_value, tz=tz)
TypeError: an integer is required (got type str)
```

I think this is because in:
https://github.com/graphql-python/gql-next/blob/5c81e58862c8df3a335b81bb2f77a0fab2c50570/gql/renderer_dataclasses.py#L153-L160

`suffix` is being overwritten if the field is nullable and `DATETIME_FIELD` isn't being used.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.