graphql-hive / graphql-hive/envelop
Compatbiility of `@envelop/rate-limiter` with `node-redis`
Open
- Dominant language
- No language data
- Stars
- 827
- Forks
- 132
- PR merge metrics
- No merged PRs in 30d
Description
**Describe the bug**
When using `@envelop/rate-limiter` with `node-redis` instead of `ioredis` it hangs due to a promise not being resolved.
The issue is that node-redis no longer supports callbacks, so the logic to resolve the created promise is not resolved/rejected:
https://github.com/graphql-hive/envelop/blob/2fa6ab7433e1e37fc88fedd2eb6b99ebaba54b14/packages/plugins/rate-limiter/src/redis-store.ts#L38
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.