graphql-hive / graphql-hive/envelop

[core] remove `useOnResolve`

Open
#2,226 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
827
Forks
132
PR merge metrics
No merged PRs in 30d

Description

## Context

`useOnResolve` plugin was created to replace `onResolve` hook that was previously available for Envelop plugins.

In our opinion, wrapping resolvers should ba avoided at any cost, since it introduced a lot of overhead and can introduce performance issues.

Also, Envelop aims to be a runtime plugin system. This means schema modifications should not be part of the plugin lifecycle and should be done at schema build time.

## Solution

Because of the point previously exposed, we should deprecate then remove this plugin.

## Additional context

This removal necessitate the refactoring of multiple plugins (mostly monitoring related):
- apollo-tracing
- newrelic
- opentelemetry
- prometheus
- rate-limiter

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.