graphql-hive / graphql-hive/envelop

[@envelop/sentry] - Spans are not added to resolvers

Open
#1,854 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
827
Forks
132
PR merge metrics
No merged PRs in 30d

Description

### Issue workflow progress

_Progress of the issue based on the
[Contributor Workflow](https://github.com/the-guild-org/Stack/blob/master/CONTRIBUTING.md#a-typical-contributor-workflow)_

- [ ] 1. The issue provides a
[minimal reproduction](https://en.wikipedia.org/wiki/Minimal_reproducible_example) available on
[Stackblitz](https://stackblitz.com/fork/node).
- _Please install the latest `@envelop/*` packages that you are using._
- _Please make sure the reproduction is as small as possible._
- [ ] 2. A failing test has been provided
- [ ] 3. A local solution has been provided
- [ ] 4. A pull request is pending review

---

**Describe the bug**

**To Reproduce** Steps to reproduce the behavior:

- Install latest version of @envelop/sentry
- Use the following settings:
```
includeRawResult: false, // set to `true` in order to include the execution result in the metadata collected
includeResolverArgs: true, // set to `true` in order to include the args passed to resolvers
includeExecuteVariables: false, // set to `true` in order to include the operation variables values
renameTransaction: true,
startTransaction: true,
```

**Expected behavior**

Spans should be added for each resolver in order to track performance of them individually

**Environment:**

- OS: Docker
- NodeJS: 18
- `@envelop/*` versions: latest
- `@envelop/core`: `???` latest

**Additional context**

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the @envelop/sentry plugin and reproduce the issue with the listed settings using the latest @envelop packages. Verify how resolver execution is instrumented and confirm that the finished change adds an individual performance span for each resolver.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
api, observability
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.