graphql-go / graphql-go/graphql

When using multi-byte runes in comments, an error occurs.

Open
#699 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
10.1k
Forks
845
PR merge metrics
No merged PRs in 30d

Description

https://github.com/graphql-go/graphql/blob/f2b39caf7c92cab3f3f92726b55f59c74f54cfbc/language/lexer/lexer.go#L132

Should i need update to ` makeToken(NAME, position, endByte, string(body[position:endByte]))`?

When i use

```
{
f(#ok
a:1)}
```
Its fine

But change to

```
{
f(#世界
a:1)}
```
Got error.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.